linux-kernel - Re: [PATCH] video: fbdev: pxafb: fix out of memory error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jan 2016 21:27:56 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Cc:	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] video: fbdev: pxafb: fix out of memory error path

Robert Jarzmik <robert.jarzmik@...e.fr> writes:

> As seen by Julia, the initial allocation memory is not checked anymore
> after commit "video: fbdev: pxafb: initial devicetree conversion".
> Introduce back the removed test.
>
> Reported-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> ---
>  drivers/video/fbdev/pxafb.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 8588dd683105..54666424a720 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2252,6 +2252,8 @@ static int pxafb_probe(struct platform_device *dev)
>  	ret = -ENOMEM;
>  	pdata = dev_get_platdata(&dev->dev);
>  	inf = devm_kmalloc(&dev->dev, sizeof(*inf), GFP_KERNEL);
> +	if (!inf)
> +		goto failed;
>  
>  	if (pdata) {
>  		*inf = *pdata;
Tomi, Jean-Christophe,

Can you carry out this fix please ?

Cheers.

-- 
Robert