linux-kernel - Re: [PATCH 1/3] mtd: nand: pxa3xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87egdpdvgt.fsf@belgarion.home>
Date:	Sun, 10 Jan 2016 21:34:58 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

Brian Norris <computersforpeace@...il.com> writes:

> On Tue, Aug 11, 2015 at 09:57:12PM +0200, Robert Jarzmik wrote:
>> @@ -127,11 +127,23 @@
>>  #define EXT_CMD_TYPE_MONO	0 /* Monolithic read/write */
>>  
>>  /* macros for registers read/write */
>> -#define nand_writel(info, off, val)	\
>> -	writel_relaxed((val), (info)->mmio_base + (off))
>> -
>> -#define nand_readl(info, off)		\
>> -	readl_relaxed((info)->mmio_base + (off))
>> +#define nand_writel(info, off, val)					\
>> +	do {								\
>> +		dev_vdbg(&info->pdev->dev,				\
>> +			 "%s():%d nand_writel(0x%x, %s)\n",		\
>> +			 __func__, __LINE__, (val), #off);		\
>
> The stringification of 'off' works for now, but I think that'd be a bit
> restrictive in the future, if we ever want to (e.g.) do arithmetic to
> compute the offset, like:
>
> 	nand_writel(info, SOME_REGISTER_MACRO + idx * 4, foo);
>
> You might be better off just printing the hex value of the offset.
Sure. I can always have a post-processing script to recreate the register names.

I'll post a v2 soon.

Cheers.

--
Robert