linux-kernel - Re: [PATCH] net: sctp: prevent writes to cookie_hmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160110.180136.2132125441173496753.davem@davemloft.net>
Date:	Sun, 10 Jan 2016 18:01:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sasha.levin@...cle.com
Cc:	vyasevich@...il.com, nhorman@...driver.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sctp: prevent writes to cookie_hmac_alg from
 accessing invalid memory

From: Sasha Levin <sasha.levin@...cle.com>
Date: Thu,  7 Jan 2016 14:52:43 -0500

> proc_dostring() needs an initialized destination string, while the one
> provided in proc_sctp_do_hmac_alg() contains stack garbage.
> 
> Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
> accessing invalid memory.
> 
> Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Applied and queued up for -stable, thanks.