linux-kernel - Re: [PATCH -next] net: ethernet: faraday: Use phy_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160110235342.GB25548@lunn.ch>
Date:	Mon, 11 Jan 2016 00:53:42 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net: ethernet: faraday: Use phy_find_first()
 instead of open coding it

On Sun, Jan 10, 2016 at 12:04:32PM -0800, Guenter Roeck wrote:
> Use phy_find_first() to find the first phy device instead of
> open coding it.
> 
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew

> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 15 ++-------------
>  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index bb116ad646f6..84384e1585a5 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -834,20 +834,9 @@ static void ftgmac100_adjust_link(struct net_device *netdev)
>  static int ftgmac100_mii_probe(struct ftgmac100 *priv)
>  {
>  	struct net_device *netdev = priv->netdev;
> -	struct phy_device *phydev = NULL;
> -	int i;
> -
> -	/* search for connect PHY device */
> -	for (i = 0; i < PHY_MAX_ADDR; i++) {
> -		struct phy_device *tmp = mdiobus_get_phy(priv->mii_bus, i);
> -
> -		if (tmp) {
> -			phydev = tmp;
> -			break;
> -		}
> -	}
> +	struct phy_device *phydev;
>  
> -	/* now we are supposed to have a proper phydev, to attach to... */
> +	phydev = phy_find_first(priv->mii_bus);
>  	if (!phydev) {
>  		netdev_info(netdev, "%s: no PHY found\n", netdev->name);
>  		return -ENODEV;
> -- 
> 2.1.4
>