linux-kernel - Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5691AC2E.2050403@cs.wisc.edu>
Date:	Sat, 09 Jan 2016 18:56:14 -0600
From:	Mike Christie <michaelc@...wisc.edu>
To:	device-mapper development <dm-devel@...hat.com>,
	mchristi@...hat.com
CC:	linux-bcache@...r.kernel.org, linux-block@...r.kernel.org,
	xfs@....sgi.com, linux-scsi@...r.kernel.org,
	konrad.wilk@...cle.com, linux-kernel@...r.kernel.org,
	philipp.reisner@...bit.com, linux-f2fs-devel@...ts.sourceforge.net,
	linux-raid@...r.kernel.org, ocfs2-devel@....oracle.com,
	target-devel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	osd-dev@...n-osd.org, linux-fsdevel@...r.kernel.org,
	lars.ellenberg@...bit.com, linux-ext4@...r.kernel.org,
	linux-btrfs@...r.kernel.org, drbd-dev@...ts.linbit.com
Subject: Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op
 fields

On 01/09/2016 07:37 AM, Christoph Hellwig wrote:
> Seems like this is missing REQ_OP_FLUSH, which still hides as a write?
> 

I might have misunderstood what you wanted or am misunderstanding you now.

I did not change the flush related code until the last patches. I added
REQ_OP_FLUSH in patch:

[PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation
commit 18dea20363ba245a47bc1bb54f6465b8a05b19af
Author: Mike Christie <mchristi@...hat.com>
Date:   Tue Jan 5 21:02:17 2016 -0600

    block, drivers: add REQ_OP_FLUSH operation


and I added the REQ_PREFLUSH flag in


[PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH
commit 303dc6a7cc3673065538ba041562fcd833a619af
Author: Mike Christie <mchristi@...hat.com>
Date:   Thu Jan 7 18:17:03 2016 -0600

    block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH


I did them in separate patches, because I was not sure if they were
correct with what you requested before, and because they were a little
more tricky because of how request_fn drivers, make_request_fn drivers,
and dm-multipath handle flushes differently.