linux-kernel - Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160111221436.GL6344@twins.programming.kicks-ass.net>
Date:	Mon, 11 Jan 2016 23:14:36 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	Ameen <ameenali023@...il.com>, mingo@...nel.org, mhocko@...e.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of
 NR_CPUS.

On Mon, Jan 11, 2016 at 02:46:22PM +0100, Vlastimil Babka wrote:
> On 01/10/2016 04:13 PM, Ameen wrote:
> > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus()..
> 
> Is that a checkpatch warning? Notice the word "often". You need to provide info
> why it's the case here (and I doubt the change will be corect in this case).

Yeah, this is terminally broken.