linux-kernel - Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160111.174547.403936696977744988.davem@davemloft.net>
Date:	Mon, 11 Jan 2016 17:45:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	manjeet.p@...sung.com
Cc:	paul.gortmaker@...driver.com, schmitzmic@...il.com,
	geert@...ux-m68k.org, nico@...xnic.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, akhilesh.k@...sung.com,
	pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as
 well.

From: Manjeet Pawar <manjeet.p@...sung.com>
Date: Mon, 11 Jan 2016 14:32:25 +0530

> This patch enable network driver support for ARM64
> 
> Signed-off-by: Akhilesh Kumar <akhilesh.k@...sung.com>
> Signed-off-by: Manjeet Pawar <manjeet.p@...sung.com>

There is no _WAY_ this is valid.

This driver casts skb->data pointers to "u32" integers
and then casts it back to a pointer and proceeds to
dereference that pointer.

I don't think you even looked at the build when trying to
compile this on a 64-bit machine.

That makes me have absolutely no confidence in the changes
you submit to me.