linux-kernel - Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160111083536.GB8070@sudip-pc>
Date:	Mon, 11 Jan 2016 14:05:36 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build
 failure

On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > If serial/atmel_serial.c is compiled with devicetree enabled, the
> > following build error is observed.
> > 
> > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > 	data definition has no type or storage class
> > drivers/tty/serial/atmel_serial.c:192:1: error:
> > 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > 	parameter names (without types) in function declaration
> > 
> > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> > 
> > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> >  drivers/tty/serial/atmel_serial.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> This hit my tree last night already with commit
> 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
> next linux-next release.

Hi Guenter,
Just a thought. It has happended many times that we both have sent
patches to fix the same build fail. Maybe your patch got applied and
mine came late or maybe mine was applied and you came late. But I think
if we have a separate mailing list where people interested to fix and
monitor build failures will be members and we Cc that list whenever we
send patch for build fail and then in that case we will know that
someone else has already sent a patch for this failure and we can invest
the time in some other problem.

regards
sudip