linux-kernel - Re: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis alignment code style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160111092454.GJ14104@x1>
Date:	Mon, 11 Jan 2016 09:24:54 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Chen-Yu Tsai <wens@...e.org>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...s.tw>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-sunxi@...glegroups.com, Hans de Goede <hdegoede@...hat.com>,
	Mark Brown <broonie@...nel.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis
 alignment code style fixes

On Thu, 17 Dec 2015, Chen-Yu Tsai wrote:

> This fixes some leftover code style issues in the axp20x core.
> 
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 631ad64ddf69..54a00168da26 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -591,14 +591,14 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  			dev_err(dev, "Unable to match OF ID\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) of_id->data;
> +		axp20x->variant = (long)of_id->data;
>  	} else {
>  		acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  		if (!acpi_id || !acpi_id->driver_data) {
>  			dev_err(dev, "Unable to match ACPI ID and data\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) acpi_id->driver_data;
> +		axp20x->variant = (long)acpi_id->driver_data;
>  	}
>  
>  	switch (axp20x->variant) {
> @@ -632,7 +632,7 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  		return -EINVAL;
>  	}
>  	dev_info(dev, "AXP20x variant %s found\n",
> -		axp20x_model_names[axp20x->variant]);
> +		 axp20x_model_names[axp20x->variant]);
>  
>  	return 0;
>  }
> @@ -652,7 +652,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	}
>  
>  	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> -			axp20x->nr_cells, NULL, 0, NULL);
> +			      axp20x->nr_cells, NULL, 0, NULL);
>  
>  	if (ret) {
>  		dev_err(axp20x->dev, "failed to add MFD devices: %d\n", ret);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog