linux-kernel - Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56937C44.9040707@arm.com>
Date:	Mon, 11 Jan 2016 09:56:20 +0000
From:	Sudeep Holla <sudeep.holla@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Sudeep Holla <sudeep.holla@....com>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	tony.luck@...el.com, qiuxishi@...wei.com,
	kamezawa.hiroyu@...fujitsu.com, mel@....ul.ie,
	dave.hansen@...el.com, matt@...eblueprint.co.uk, arnd@...db.de,
	steve.capper@...aro.org
Subject: Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror
 option



On 08/01/16 23:12, Andrew Morton wrote:
> On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla <sudeep.holla@....com> wrote:
>
>>> +
>>> +			/*
>>> +			 * if not mirrored_kernelcore and ZONE_MOVABLE exists,
>>> +			 * range from zone_movable_pfn[nid] to end of each node
>>> +			 * should be ZONE_MOVABLE not ZONE_NORMAL. skip it.
>>> +			 */
>>> +			if (!mirrored_kernelcore && zone_movable_pfn[nid])
>>> +				if (zone == ZONE_NORMAL &&
>>> +				    pfn >= zone_movable_pfn[nid])
>>> +					continue;
>>> +
>>
>> I tried this with today's -next, the above lines gave compilation error.
>> Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64.
>> I don't see the previous backtraces. Let me know if that's correct or
>> you can post a version that compiles correctly and I can give a try.
>
> Thanks.   I'll include the below and shall add your tested-by:, OK?
>

Yes this is the exact change I tested. Also I retested your latest patch
set with today's -next. So,

Tested-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep