linux-kernel - Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56930E05.1050009@huawei.com>
Date:	Mon, 11 Jan 2016 10:05:57 +0800
From:	xuejiancheng <xuejiancheng@...wei.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	<mturquette@...libre.com>, <sboyd@...eaurora.org>,
	<p.zabel@...gutronix.de>, <robh+dt@...nel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<khilman@...aro.org>, <arnd@...db.de>, <olof@...om.net>,
	<xuwei5@...ilicon.com>, <haojian.zhuang@...aro.org>,
	<zhangfei.gao@...aro.org>, <bintian.wang@...wei.com>,
	<linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <yanhaifeng@...ilicon.com>,
	<yanghongwei@...ilicon.com>, <suwenping@...ilicon.com>,
	<ml.yang@...ilicon.com>, <gaofei@...ilicon.com>,
	<zhangzhenxing@...ilicon.com>, <xuejiancheng@...ilicon.com>
Subject: Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519

Hello Russell,

On 2016/1/8 23:10, Russell King - ARM Linux wrote:
> On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
>> +		uart0: serial@...00000 {
>> +			compatible = "arm,pl011", "arm,primecell";
>> +			reg = <0x12100000 0x1000>;
>> +			interrupts = <0 4 4>;
> 
> Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
> other interrupts= after this?)
> 
> Thanks.
> 

I'll include <dt-bindings/interrupt-controller/arm-gic.h> and use
IRQ_TYPE_LEVEL_HIGH instead. The interrupts specifier will be wrote
like this "interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;".

Thank you.

Jiancheng