linux-kernel - Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160111102117.GU14104@x1>
Date:	Mon, 11 Jan 2016 10:21:17 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Milo Kim <milo.kim@...com>
Cc:	robh+dt@...nel.org, j.anaszewski@...sung.com, broonie@...nel.org,
	devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver

On Thu, 26 Nov 2015, Milo Kim wrote:

> LM3633 and LM3697 are TI LMU MFD device.
> Those devices have hardware monitoring feature which detects open or
> short circuit case.
> 
> Debugfs
> -------
>   Two files are created.
>     open_fault:  check light output channel is open or not.
>     short_fault: check light output channel is shorted or not.
> 
>   The driver checks the status of backlight output channels.
>   LM3633 and LM3697 have same sequence to check channels, so common
>   functions are used.
>   ABI/testing document is also included.
> 
> Operations
> ----------
>   Two devices have common control flow but register addresses are different.
>   The structure, 'ti_lmu_reg' is used for register configuration.
> 
> Event notifier
> --------------
>   After fault monitoring is done, LMU device is reset. So backlight and
>   LED device should be reinitialized. It notifies an event as soon as
>   the monitoring is done. Then, LM3633 and LM3697 backlight and LED drivers
>   handle this event.
> 
> Cc: Lee Jones <lee.jones@...aro.org> 
> Cc: Jacek Anaszewski <j.anaszewski@...sung.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Cc: linux-leds@...r.kernel.org 
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Milo Kim <milo.kim@...com>
> ---
>  .../ABI/testing/debugfs-ti-lmu-fault-monitor       |  32 ++
>  drivers/mfd/Kconfig                                |  10 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/ti-lmu-fault-monitor.c                 | 405 +++++++++++++++++++++

I think this device is part of the MFD, rather than an MFD itself.
Please relocate it to somewhere more appropriate.

>  4 files changed, 448 insertions(+)
>  create mode 100644 Documentation/ABI/testing/debugfs-ti-lmu-fault-monitor
>  create mode 100644 drivers/mfd/ti-lmu-fault-monitor.c

[...]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog