linux-kernel - Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452515294.26146.10.camel@linux.intel.com>
Date:	Mon, 11 Jan 2016 14:28:14 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Anton Wuerfel <anton.wuerfel@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Peter Hurley <peter@...leysoftware.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Qipeng Zha <qipeng.zha@...el.com>,
	Desmond Liu <desmondl@...adcom.com>,
	Wang Long <long.wanglong@...wei.com>,
	Matt Redfearn <matt.redfearn@...tec.com>,
	Paul Burton <paul.burton@...tec.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Peter Hung <hpeter@...il.com>,
	Soeren Grunewald <soeren.grunewald@...y.de>,
	Adam Lee <adam.lee@...onical.com>,
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
	Mans Rullgard <mans@...sr.com>, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-kernel@...cs.fau.de,
	phillip.raffeck@....de
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes whitespace errors reported by checkpatch to increase
> readability. Main focus is on missing spaces after commas in
> function headers and macros (like foo,bar edited to foo, bar).
> 
> Signed-off-by: Anton Würfel <anton.wuerfel@....de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@....de>
> CC: linux-kernel@...cs.fau.de

Cc: looks more standard.

> --- a/drivers/tty/serial/8250/8250_accent.c
> +++ b/drivers/tty/serial/8250/8250_accent.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

While those are okay, I would suggest to make a macro in
drivers/…/8250.h one for all, something like this:

#define 8250_PORT_FLAGS(_base, _irq, _flags)
…
	.flags          = UPF_BOOT_AUTOCONF | (_flags) \

#define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)

And use it.

> --- a/drivers/tty/serial/8250/8250_boca.c
> +++ b/drivers/tty/serial/8250/8250_boca.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_exar_st16c554.c
> +++ b/drivers/tty/serial/8250/8250_exar_st16c554.c
> @@ -13,7 +13,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)				\
> +#define PORT(_base, _irq)				\
>  	{						\
>  		.iobase		= _base,		\
>  		.irq		= _irq,			\
> 

> --- a/drivers/tty/serial/8250/8250_fourport.c
> +++ b/drivers/tty/serial/8250/8250_fourport.c
> @@ -10,7 +10,7 @@
>  #include <linux/init.h>
>  #include <linux/serial_8250.h>
>  
> -#define PORT(_base,_irq)						
> \
> +#define PORT(_base, _irq)						
> \
>  	{								
> \
>  		.iobase		= _base,			
> 	\
>  		.irq		= _irq,				
> 	\



-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy