linux-kernel - Re: [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452515914.26146.14.camel@linux.intel.com>
Date:	Mon, 11 Jan 2016 14:38:34 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Anton Wuerfel <anton.wuerfel@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jiri Slaby <jslaby@...e.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Peter Hurley <peter@...leysoftware.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Qipeng Zha <qipeng.zha@...el.com>,
	Desmond Liu <desmondl@...adcom.com>,
	Wang Long <long.wanglong@...wei.com>,
	Matt Redfearn <matt.redfearn@...tec.com>,
	Paul Burton <paul.burton@...tec.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Peter Hung <hpeter@...il.com>,
	Soeren Grunewald <soeren.grunewald@...y.de>,
	Adam Lee <adam.lee@...onical.com>,
	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
	Mans Rullgard <mans@...sr.com>, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-kernel@...cs.fau.de,
	phillip.raffeck@....de
Subject: Re: [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk

On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> From: Phillip Raffeck <phillip.raffeck@....de>
> 
> This patch replaces printk by the corresponding variant of dev_* in
> order
> to fix checkpatch warnings. If no suitable device pointer is present,
> the
> corresponding pr_* variant is used.
> 

> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> 

> @@ -141,13 +141,13 @@ int __init hp300_setup_serial_console(void)
>  		if (DIO_ID(pa + DIO_VIRADDRBASE) & 0x80)
>  			add_preferred_console("ttyS", port.line,
> "9600n8");
>  #else
> -		printk(KERN_WARNING "Serial console is DCA but
> support is disabled (CONFIG_HPDCA)!\n");
> +		pr_warn("Serial console is DCA but support is
> disabled (CONFIG_HPDCA)!\n");
>  		return 0;
>  #endif
>  	}
>  
>  	if (early_serial_setup(&port) < 0)
> -		printk(KERN_WARNING "hp300_setup_serial_console():
> early_serial_setup() failed.\n");
> +		pr_warn("hp300_setup_serial_console():
> early_serial_setup() failed.\n");

%s:…, __func__ ?

>  	return 0;
>  }
>  #endif /* CONFIG_SERIAL_8250_CONSOLE */
> @@ -179,8 +179,9 @@ static int hpdca_init_one(struct dio_dev *d,
>  	line = serial8250_register_8250_port(&uart);
>  
>  	if (line < 0) {
> -		printk(KERN_NOTICE "8250_hp300: register_serial()
> DCA scode %d"
> -		       " irq %d failed\n", d->scode, uart.port.irq);
> +		dev_notice(&d->dev,
> +			  "8250_hp300: register_serial() DCA scode
> %d irq %d failed\n",
> +			  d->scode, uart.port.irq);
>  		return -ENOMEM;
>  	}
>  
> @@ -260,8 +261,8 @@ static int __init hp300_8250_init(void)
>  		line = serial8250_register_8250_port(&uart);
>  
>  		if (line < 0) {
> -			printk(KERN_NOTICE "8250_hp300:
> register_serial() APCI"
> -			       " %d irq %d failed\n", i,
> uart.port.irq);
> +			pr_notice("8250_hp300: register_serial()
> APCI %d irq %d failed\n",
> +				  i, uart.port.irq);

Inconsistent with dev_notice() above. Choose one which is most suitable
here.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy