linux-kernel - Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1x7fjgxonh.fsf@unicorn.mansr.com>
Date:	Mon, 11 Jan 2016 12:54:10 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	"Shevchenko\, Andriy" <andriy.shevchenko@...el.com>
Cc:	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"anton.wuerfel\@fau.de" <anton.wuerfel@....de>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"mail\@maciej.szmigiero.name" <mail@...iej.szmigiero.name>,
	"desmondl\@broadcom.com" <desmondl@...adcom.com>,
	"Zha\, Qipeng" <qipeng.zha@...el.com>,
	"heikki.krogerus\@linux.intel.com" <heikki.krogerus@...ux.intel.com>,
	"long.wanglong\@huawei.com" <long.wanglong@...wei.com>,
	"soeren.grunewald\@desy.de" <soeren.grunewald@...y.de>,
	"deller\@gmx.de" <deller@....de>,
	"jslaby\@suse.com" <jslaby@...e.com>,
	"phillip.raffeck\@fau.de" <phillip.raffeck@....de>,
	"paul.burton\@imgtec.com" <paul.burton@...tec.com>,
	"hpeter\@gmail.com" <hpeter@...il.com>,
	"ralf\@linux-mips.org" <ralf@...ux-mips.org>,
	"linux-kernel\@i4.cs.fau.de" <linux-kernel@...cs.fau.de>,
	"adam.lee\@canonical.com" <adam.lee@...onical.com>,
	"jejb\@parisc-linux.org" <jejb@...isc-linux.org>,
	"linux-parisc\@vger.kernel.org" <linux-parisc@...r.kernel.org>,
	"peter\@hurleysoftware.com" <peter@...leysoftware.com>,
	"matt.redfearn\@imgtec.com" <matt.redfearn@...tec.com>,
	"k.kozlowski\@samsung.com" <k.kozlowski@...sung.com>
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors

"Shevchenko, Andriy" <andriy.shevchenko@...el.com> writes:

> On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
>> On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
>> > This patch fixes whitespace errors reported by checkpatch to
>> > increase
>> > readability. Main focus is on missing spaces after commas in
>> > function headers and macros (like foo,bar edited to foo, bar).
>> > 
>> > Signed-off-by: Anton Würfel <anton.wuerfel@....de>
>> > Signed-off-by: Phillip Raffeck <phillip.raffeck@....de>
>> > CC: linux-kernel@...cs.fau.de
>> 
>> Cc: looks more standard.
>> 
>> > --- a/drivers/tty/serial/8250/8250_accent.c
>> > +++ b/drivers/tty/serial/8250/8250_accent.c
>> > @@ -10,7 +10,7 @@
>> >  #include <linux/init.h>
>> >  #include <linux/serial_8250.h>
>> >  
>> > -#define PORT(_base,_irq)				\
>> > +#define PORT(_base, _irq)				\
>> >  	{						\
>> >  		.iobase		= _base,		\
>> >  		.irq		= _irq,			
>> > \
>
> 8250_PORT()
>
>> > 
>> 
>> While those are okay, I would suggest to make a macro in
>> drivers/…/8250.h one for all, something like this:
>> 
>> #define 8250_PORT_FLAGS(_base, _irq, _flags)
>> …
>> 	.flags          = UPF_BOOT_AUTOCONF | (_flags) \
>> 
>> #define 8250_PORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq, 0)
>> 
>> And use it.
>
> #define 8250_FOURPORT(_base, _irq)	8250_PORT_FLAGS(_base, _irq,
> UPF_FOURPORT)

Macro names can't start with a number.

-- 
Måns Rullgård