linux-kernel - Re: [PATCH] mm: add ratio in slabinfo print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160111133950.GC27317@dhcp22.suse.cz>
Date:	Mon, 11 Jan 2016 14:39:52 +0100
From:	Michal Hocko <mhocko@...nel.org>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	cl@...ux.com, Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>, iamjoonsoo.kim@....com,
	Andrew Morton <akpm@...ux-foundation.org>,
	zhong jiang <zhongjiang@...wei.com>,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: add ratio in slabinfo print

On Mon 11-01-16 21:15:01, Xishi Qiu wrote:
> On 2016/1/11 20:25, Michal Hocko wrote:
> 
> > On Mon 11-01-16 11:54:57, Xishi Qiu wrote:
> >> Add ratio(active_objs/num_objs) in /proc/slabinfo, it is used to show
> >> the availability factor in each slab.
> > 
> > What is the reason to add such a new value when it can be trivially
> > calculated from the userspace?
> > 
> > Besides that such a change would break existing parsers no?
> 
> Oh, maybe it is.
> 
> How about adjustment the format because some names are too long?

Parsers should be clever enough to process white spaces properly but
there is no guarantee this will be the case. A more important question
is whether it really makes sense to change this in the first place. What
would be the benefit? Somehow nicer output? Does this justify a potential
breakage of tool processing this file? To me this all sounds like such a
change is not worth it.
-- 
Michal Hocko
SUSE Labs