linux-kernel - Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5693B347.7050905@suse.cz>
Date:	Mon, 11 Jan 2016 14:51:03 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	"Kirill A. Shutemov" <kirill@...temov.name>,
	Alexander Kuleshov <kuleshovmail@...il.com>,
	Robin Holt <holt@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Michal Hocko <mhocko@...e.com>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <js1304@...il.com>,
	Yaowei Bai <bywxiaobai@....com>,
	Xishi Qiu <qiuxishi@...wei.com>,
	Alexander Duyck <alexander.h.duyck@...hat.com>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	Johannes Weiner <hannes@...xchg.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable

On 01/09/2016 12:29 AM, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
>> This patch removes unused struct zone *z variable which is
>> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
> 
> I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
> into a separate function).

Yeah but it's not a bug, so a tag like that would be just noise.

>> 
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

>> ---
>>  mm/page_alloc.c | 2 --
>>  1 file changed, 2 deletions(-)
>> 
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 9d666df..9bde098 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>>  	pg_data_t *pgdat = NODE_DATA(nid);
>>  	unsigned long end_pfn = start_pfn + size;
>>  	unsigned long pfn;
>> -	struct zone *z;
>>  	unsigned long nr_initialised = 0;
>>  
>>  	if (highest_memmap_pfn < end_pfn - 1)
>>  		highest_memmap_pfn = end_pfn - 1;
>>  
>> -	z = &pgdat->node_zones[zone];
>>  	for (pfn = start_pfn; pfn < end_pfn; pfn++) {
>>  		/*
>>  		 * There can be holes in boot-time mem_map[]s
>> -- 
>> 2.6.2.485.g1bc8fea
>> 
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@...ck.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>