linux-kernel - Re: Correct place for USB PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3956038.NYKA2GIJmd@wuerfel>
Date:	Mon, 11 Jan 2016 14:55:27 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Mason <slash.tmp@...e.fr>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Felipe Balbi <balbi@...com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-usb <linux-usb@...r.kernel.org>
Subject: Re: Correct place for USB PHY driver

On Monday 11 January 2016 12:56:27 Mason wrote:
> On 11/01/2016 11:28, Kishon Vijay Abraham I wrote:
> 
> > On Monday 11 January 2016 03:37 PM, Mason wrote:
> >
> >> I have a board with a Chipidea controller.
> >> I use a custom PHY driver for it.
> >>
> >> Should the PHY driver live in drivers/phy or in drivers/usb/phy ?
> > 
> > All new phy drivers should be in drivers/phy using the generic PHY framework.
> >
> >> I was playing with a modular build and hit this problem:
> >> ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!
> >>
> >> I'm currently using v4.1.13 and I saw that Arnd fixed something related
> >> probably in a later version:
> >>
> >>   http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561
> >>
> >> Was this patch accepted upstream?
> > 
> > I think no.
> 
> The driver I use is in drivers/phy and my config has
> 
> CONFIG_GENERIC_PHY=y
> # CONFIG_USB_PHY is not set
> 
> But I do hit the "of_usb_get_phy_mode undefined" error when I
> set all of USB to m.
> 
> Arnd, do you think your patch needs to be carried over to generic PHY?

I think my patch is still needed, I will resubmit it if it doesn't make
it into 4.5-rc1.

In the meantime you can work around the problem by setting CONFIG_USB=y
instead of CONFIG_USB=m.

	Arnd