linux-kernel - Re: [PATCH v2] mtd: spi-nor: add hisilicon spi-nor flash controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+K-tF=snhq+w9yYQKmAxbxDSLq6cv5fLfWjHTgdJxQWQ@mail.gmail.com>
Date:	Sun, 10 Jan 2016 21:09:31 -0600
From:	Rob Herring <robh@...nel.org>
To:	xuejiancheng <xuejiancheng@...wei.com>
Cc:	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	shijie.huang@...el.com, pengbinquan@...wei.com,
	han.xu@...escale.com,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Joachim Eastwood <manabian@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	yanhaifeng@...ilicon.com, yanghongwei@...ilicon.com,
	suwenping@...ilicon.com, ml.yang@...ilicon.com,
	gaofei@...ilicon.com, zhangzhenxing@...ilicon.com,
	xuejiancheng@...ilicon.com
Subject: Re: [PATCH v2] mtd: spi-nor: add hisilicon spi-nor flash controller driver

On Sun, Jan 10, 2016 at 7:20 PM, xuejiancheng <xuejiancheng@...wei.com> wrote:
> Hi Rob,
>
> On 2016/1/9 23:42, Rob Herring wrote:
>> On Fri, Jan 08, 2016 at 09:26:45AM +0800, Jiancheng Xue wrote:
>>> add hisilicon spi-nor flash controller driver
>>>
>>> Signed-off-by: Binquan Peng <pengbinquan@...wei.com>
>>> Signed-off-by: Jiancheng Xue <xuejiancheng@...wei.com>
>>> ---

>>> +Required properties:
>>> +- compatible : Should be "hisilicon,hisi-sfc".
>>
>> I missed this last time, but you also need a more specific compatible
>> string with the SOC name in it.
>>
>
> This IP block is used in many SOCs. Do I need to add a specific compatible
> string for every SOC? Thank you.

Yes. You can keep the generic one for driver matching, but you want to
have the specific one in case there ever is a quirk/errata in a
specific SOC.

Rob