linux-kernel - Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 14:14:00 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Viresh Kumar <vireshk@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks

Viresh Kumar <viresh.kumar@...aro.org> writes:

> On 11-01-16, 13:04, Mans Rullgard wrote:
>> Cyclic transfer callbacks rely on block completion interrupts which were
>> disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block
>> interrupts").  This re-enables block interrupts so the cyclic callbacks
>> can work.  Other transfer types are not affected as they set the INT_EN
>> bit only on the last block.
>> 
>> Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block interrupts")
>> Signed-off-by: Mans Rullgard <mans@...sr.com>
>> ---
>> Changes:
>> - new patch
>> ---
>>  drivers/dma/dw/core.c | 21 +++++++++++++++------
>>  1 file changed, 15 insertions(+), 6 deletions(-)
>
> Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> BTW, Shouldn't you mark these for stable trees as well ? :)

Probably.  Some maintainers prefer to do that themselves, but apparently
you're not one of them.

-- 
Måns Rullgård