linux-kernel - Re: [PATCH 11/53] perf test: Fix false TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5693BB6C.9060900@cogentembedded.com>
Date:	Mon, 11 Jan 2016 17:25:48 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Wang Nan <wangnan0@...wei.com>, acme@...nel.org
Cc:	linux-kernel@...r.kernel.org, pi3orama@....com, lizefan@...wei.com,
	netdev@...r.kernel.org, davem@...emloft.net,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH 11/53] perf test: Fix false TEST_OK result for 'perf test
 hist'

On 01/11/2016 04:48 PM, Wang Nan wrote:

> Commit 71d6de64feddd4b455555326fba2111b3006d9e0 ('perf test: Fix hist
> testcases when kptr_restrict is on') solves a double free problem when

    You didn't run this patch thru scripts/checkpatch.pl, I guess? A certain 
commit citing style is enforced now, and yours doesn't quite match it...

> 'perf test hist' calling setup_fake_machine(). However, the result is
> still incorrect. For example:
>
>   $ ./perf test -v 'filtering hist entries'
>   25: Test filtering hist entries                              :
>   --- start ---
>   test child forked, pid 4186
>   Cannot create kernel maps
>   test child finished with 0
>   ---- end ----
>   Test filtering hist entries: Ok
>
> In this case the body of this test is not get executed at all, but the
> result is 'Ok'.
>
> Actually, in setup_fake_machine() there's no need to create real kernel
> maps. What we want is the fake maps. This patch removes the
> machine__create_kernel_maps() in setup_fake_machine(), so it won't be
> affected by kptr_restrict setting.
>
> Test result:
>
>   $ cat /proc/sys/kernel/kptr_restrict
>   1
>   $ ~/perf test -v hist
>   15: Test matching and linking multiple hists                 :
>   --- start ---
>   test child forked, pid 24031
>   test child finished with 0
>   ---- end ----
>   Test matching and linking multiple hists: Ok
>   [SNIP]
>
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Suggested-by: Namhyung Kim <namhyung@...nel.org>
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
[...]

MBR, Sergei