linux-kernel - Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5693C756.8010108@windriver.com>
Date:	Mon, 11 Jan 2016 10:16:38 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Manjeet Pawar <manjeet.p@...sung.com>, <davem@...emloft.net>,
	<schmitzmic@...il.com>, <geert@...ux-m68k.org>, <nico@...xnic.net>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<akhilesh.k@...sung.com>
CC:	<pankaj.m@...sung.com>
Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well.

On 2016-01-11 04:02 AM, Manjeet Pawar wrote:
> This patch enable network driver support for ARM64

Your commit log only repeats what is obvious from the one line
change itself.  It might be nice to indicate what platform it
was validated on, what tests were run and what features of the
driver were exercised (multicast, netpoll, ...)

Imagine if I sent you a similar patch where I added MIPS and
said nothing more than "enable network driver support for MIPS"
and Cc'd you expecting you to comment on whether it was OK.

Thanks,
Paul.
--

> 
> Signed-off-by: Akhilesh Kumar <akhilesh.k@...sung.com>
> Signed-off-by: Manjeet Pawar <manjeet.p@...sung.com>
> ---
>  drivers/net/ethernet/smsc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
> index eb9230e..6e73c73 100644
> --- a/drivers/net/ethernet/smsc/Kconfig
> +++ b/drivers/net/ethernet/smsc/Kconfig
> @@ -77,7 +77,7 @@ config SMC911X
>  	tristate "SMSC LAN911[5678] support"
>  	select CRC32
>  	select MII
> -	depends on (ARM || SUPERH || MN10300)
> +	depends on (ARM || ARM64 || SUPERH || MN10300)
>  	---help---
>  	  This is a driver for SMSC's LAN911x series of Ethernet chipsets
>  	  including the new LAN9115, LAN9116, LAN9117, and LAN9118.
>