linux-kernel - Re: [PATCH v4 1/5] platform:x86: Add Intel Telemetry Core Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160111182234.GB10643@malice.jf.intel.com>
Date:	Mon, 11 Jan 2016 10:22:34 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>
Cc:	platform-driver-x86@...r.kernel.org, rjw@...ysocki.net,
	linux-kernel@...r.kernel.org, srinidhi.kasagar@...el.com,
	qipeng.zha@...el.com, rajeev.d.muralidhar@...el.com,
	sukumar.ghorai@...el.com, ong.hock.yu@...el.com,
	aubrey.li@...el.com, david.ginat@...el.com
Subject: Re: [PATCH v4 1/5] platform:x86: Add Intel Telemetry Core Driver

On Thu, Jan 07, 2016 at 02:35:29PM +0530, Souvik Kumar Chakravarty wrote:
> Intel PM Telemetry is a software mechanism via which various SoC
> PM and performance related parameters like PM counters, firmware
> trace verbosity, the status of different devices inside the SoC, etc
> can be monitored and analyzed. The different samples that may be
> monitored can be configured at runtime via exported APIs.
> 
> This patch adds the telemetry core driver that implements basic
> exported APIs.
> 
> Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>
> ---
>  arch/x86/include/asm/intel_telemetry.h      |  147 +++++++++
>  drivers/platform/x86/intel_telemetry_core.c |  464 +++++++++++++++++++++++++++
>  2 files changed, 611 insertions(+)
>  create mode 100644 arch/x86/include/asm/intel_telemetry.h
>  create mode 100644 drivers/platform/x86/intel_telemetry_core.c
> 
> diff --git a/arch/x86/include/asm/intel_telemetry.h b/arch/x86/include/asm/intel_telemetry.h
> new file mode 100644
> index 0000000..ed65fe7
> --- /dev/null
> +++ b/arch/x86/include/asm/intel_telemetry.h

This file doesn't exist yet, and the compile fails with just this patch applied.

Souvik, please test each patch individually. The idea is to add independent
functional blocks such that they are easier to understand and review, but they
must be complete and cannot break the build.

Typically this would be something more like:

1 core
2 platform
3 debugfs

The MAINTAINERS and Makefile should be changed within each patch for the files
they affect (checkpatch enforces MAINTAIENRS).

It still won't build after patch 2/5 when the Makefile target is introduced.

-- 
Darren Hart
Intel Open Source Technology Center