linux-kernel - Re: [PATCH v6] iio: add ad5761 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 19:28:17 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] iio: add ad5761 DAC driver

On 11/01/16 19:26, Ricardo Ribalda Delgado wrote:
> Hello Jonathan
> 
> On Mon, Jan 11, 2016 at 8:24 PM, Jonathan Cameron <jic23@...nel.org> wrote:
>> On 11/01/16 16:23, Ricardo Ribalda Delgado wrote:
>>> ad5761 is a 1-channel DAC with configurable output range.
>>> The driver uses the regulator interface for its voltage ref.
>>>
>>> It shares its register layout with ad5761r, ad5721 and ad5721r.
>>>
>>> Differences:
>>> ad5761* are 16 bit, ad5721* are 12 bits.
>>> ad57*1r have an internal reference.
>>>
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>> Just that unnecessary null check left as far as I'm concerned.
>> I'd like to leave this a little while for others to take a look
>> if they like as well.
> 
> Shall i send v7 with that fixed or I wait?
Up to you.  I doubt it will hold others back from commenting, but then
they might not comment and you'll have to remember to send it in a couple
of days....
> 
> 
> Regards!
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>