linux-kernel - Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201601112103.01145@pali>
Date:	Mon, 11 Jan 2016 21:03:01 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Darren Hart <dvhart@...radead.org>, Pavel Machek <pavel@....cz>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Fabio D'Urso" <fabiodurso@...mail.it>
Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> The two features are not the same (and are handled differently by the
> firmware, for whatever reason), although they do serve the same
> purpose. I don't think a thinkpad will ever have both features at
> the same time, so I have no idea why they changed the firmware
> interface.

Maybe we should decide if ::kbd_backlight LED suffix could be used also 
for other LED devices and not only for those which are physically under 
the keyboard.

At least I understand "keyboard backlight" as light which is under the 
keyboard...

And more important, I was told that ThinkPad x230 comes in variant with 
both ThinkLight (that LED upper the display) and keyboard backlight 
(under they keyboard).

So I'm against merging ThinkLight and keyboard backlight to one sysfs 
path...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)