linux-kernel - Re: [PATCH v1] mm: soft-offline: check return value in second __get_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160112140939.26df8a425422341bb899ee6f@linux-foundation.org>
Date:	Tue, 12 Jan 2016 14:09:39 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Naoya Horiguchi <nao.horiguchi@...il.com>
Subject: Re: [PATCH v1] mm: soft-offline: check return value in second
 __get_any_page() call

On Tue, 12 Jan 2016 03:29:35 +0000 Naoya Horiguchi <n-horiguchi@...jp.nec.com> wrote:

> > I don't understand what you're asking for.  Please be very
> > specific and carefully identify patches by filename or Subject:.
> 
> OK, so what I really wanted is that (1) applying this patch just before
> http://ozlabs.org/~akpm/mmots/broken-out/mm-hwpoison-adjust-for-new-thp-refcounting.patch
> and (2) removing the following chunk from the mm-hwpoison-adjust-for-new-thp-refcounting.patch:
> 
> @@ -1575,7 +1540,7 @@ static int get_any_page(struct page *pag
>  		 * Did it turn free?
>  		 */
>  		ret = __get_any_page(page, pfn, 0);
> -		if (!PageLRU(page)) {
> +		if (ret == 1 && !PageLRU(page)) {
>  			/* Drop page reference which is from __get_any_page() */
>  			put_hwpoison_page(page);
>  			pr_info("soft_offline: %#lx: unknown non LRU page type %lx\n",

Not a problem, thanks.