linux-kernel - Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing l2c from dtb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <56959275.80404@samsung.com>
Date:	Wed, 13 Jan 2016 08:55:33 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Andi Shyti <andi.shyti@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	linux@....linux.org.uk, tony@...mide.com, robh@...nel.org,
	tglx@...utronix.de, olof@...om.net, tomasz.figa@...il.com,
	jiang.liu@...ux.intel.com, yamada.masahiro@...ionext.com,
	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	andi@...zian.org
Subject: Re: [PATCH v3] arm: irq: l2c: do not print error in case of missing
 l2c from dtb

On 12.01.2016 19:11, Andi Shyti wrote:
> In some architectures the L2 cache controller is integrated in the
> processor's block itself and it doesn't use any external cache
> controller. This means that an entry in the board's dtb related
> to the l2c is not necessary.
> 
> Distinguish between error codes and do not print anything in case
> l2x0_of_init() doesn't find any L2C DTB entry and returns -ENODEV.
> 
> This patch mutes the following error message:
> 
>    L2C: failed to init: -19
> 
> on boards like odroid-xu4, cortex A7/A15, which don't have
> external cache controller.
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> Reported-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
> Hi,
> 
> here is a second version. An alternative would be to print with
> pr_dbg, but then it's a matter of taste.
> 
> V1, and V2 print a message in case the l2c dtb entry is not found
> (the V2 has a better print rephrase suggested by Joe)
> 
> V3 ignores the case of -enodev for l2c and doesn't print anything
> 
> Thanks,
> Andi

Looks good to me, as v2 did. Works fine:
Tested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

BR,
KRzysztof