linux-kernel - Re: [PATCH v7] iio: add ad5761 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56941920.8020406@metafoo.de>
Date:	Mon, 11 Jan 2016 22:05:36 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] iio: add ad5761 DAC driver

On 01/11/2016 08:32 PM, Ricardo Ribalda Delgado wrote:
> ad5761 is a 1-channel DAC with configurable output range.
> The driver uses the regulator interface for its voltage ref.
> 
> It shares its register layout with ad5761r, ad5721 and ad5721r.
> 
> Differences:
> ad5761* are 16 bit, ad5721* are 12 bits.
> ad57*1r have an internal reference.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>

Looks very clean now, thanks. I have just one comment I overlooked during
the first review. When that's addresses feel free to add

Reviewed-by: Lars-Peter Clausen <lars@...afoo.de>

And one wish for the future, please give people a chance a review and don't
resend a new version of the patch every couple of hours. This will make the
reviewers life a bit easier.

> diff --git a/include/linux/iio/dac/ad5761.h b/include/linux/iio/dac/ad5761.h
> new file mode 100644
> index 000000000000..2f3702309d61
> --- /dev/null
> +++ b/include/linux/iio/dac/ad5761.h

This should go into include/linux/platform_data. That's where all new
platform data include files should go.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)