linux-kernel - RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2016 08:23:02 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Javier Martinez Canillas <javier@...hile0.org>
CC:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A

Hi Javier,

Thank you for your review.

> -----Original Message-----
> From: Javier Martinez Canillas [mailto:javier@...hile0.org]
> Sent: 2016年1月8日 23:00
> To: Yang, Wenyou <Wenyou.Yang@...el.com>
> Cc: Sebastian Reichel <sre@...nel.org>; Dmitry Eremin-Solenikov
> <dbaryshkov@...il.com>; David Woodhouse <dwmw2@...radead.org>; Rob
> Herring <robh+dt@...nel.org>; Pawel Moll <pawel.moll@....com>; Mark
> Rutland <mark.rutland@....com>; Ian Campbell <ijc+devicetree@...lion.org.uk>;
> Kumar Gala <galak@...eaurora.org>; Ferre, Nicolas
> <Nicolas.FERRE@...el.com>; linux-arm-kernel@...ts.infradead.org; Linux
> Kernel <linux-kernel@...r.kernel.org>; linux-pm@...r.kernel.org
> Subject: Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
> 
> Hello Wenyou,
> 
> On Thu, Jan 7, 2016 at 11:13 PM, Wenyou Yang <wenyou.yang@...el.com>
> wrote:
> > This patch adds new driver for Active-semi ACT8945A ActivePath charger
> > (part of ACT8945A MFD driver) providing power supply class information
> > to userspace.
> >
> > The driver is configured through DTS (battery and system related
> > settings) and sysfs entries (timers and input over-voltage threshold).
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> > ---
> >
> 
> [snip]
> 
> > +
> > +static struct platform_driver act8945a_charger_driver = {
> > +       .driver = {
> > +               .name = "act8945a-charger",
> > +       },
> > +       .probe  = act8945a_charger_probe,
> > +       .remove = act8945a_charger_remove, };
> > +
> 
> The driver is missing an OF match table (and also a platform ID match table if
> non-DT is supported) so this means that module autoloading will be broken for this
> driver since the platform uevent function will report a MODALIAS=of:N*T*Cactive-
> semi,act8945a-charger

This is an MFD device, it compatible is declared in the ../mfd/act8945a.c file.

	.of_compatible = "active-semi,act8945a-charger".

The non-DT  is not supported in this patch. So a platform ID match table is not included.

> 
> Matching is only working because the platform bus match function use as a
> fallback the driver name.


> 
> Best regards,
> Javier


Best Regards,
Wenyou Yang