linux-kernel - Re: [PATCH] uapi: update install list after nvme.h rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5694BD46.3030004@suse.cz>
Date:	Tue, 12 Jan 2016 09:45:58 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Mike Frysinger <vapier@...too.org>, linux-kernel@...r.kernel.org
Cc:	hch@....de, keith.busch@...el.com, axboe@...com,
	stable@...r.kernel.org
Subject: Re: [PATCH] uapi: update install list after nvme.h rename

On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
> Commit 9d99a8dda154 ("nvme: move hardware structures out of the uapi
> version of nvme.h") renamed nvme.h to nvme_ioctl.h, but the uapi list
> still refers to nvme.h.  People trying to install the headers hit a
> failure as the header no longer exists.

Wouldn't reverting the rename be nicer to userspace? So that the
filename is preserved and anybody who #included nvme.h still can do so?

> Cc: stable@...r.kernel.org
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  include/uapi/linux/Kbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
> index dc6172c..7bb6aeb 100644
> --- a/include/uapi/linux/Kbuild
> +++ b/include/uapi/linux/Kbuild
> @@ -307,7 +307,7 @@ header-y += nfs_mount.h
>  header-y += nl80211.h
>  header-y += n_r3964.h
>  header-y += nubus.h
> -header-y += nvme.h
> +header-y += nvme_ioctl.h
>  header-y += nvram.h
>  header-y += omap3isp.h
>  header-y += omapfb.h
> 


-- 
js
suse labs