linux-kernel - Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <56944E49.3040707@samsung.com>
Date:	Tue, 12 Jan 2016 09:52:25 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Guenter Roeck <linux@...ck-us.net>, Kukjin Kim <kgene@...nel.org>
Cc:	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410

On 12.01.2016 02:00, Guenter Roeck wrote:
> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
> 
> This results in the following build error.
> 
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	(near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
> 	invalid use of undefined type 'struct bgpio_pdata'
> 
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.
> 
>  arch/arm/mach-s3c64xx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks for the report! I think that:

1. Other boards using the bgpio_pdata might be also affected:
mach-clps711x/board-autcpu12.c
mach-clps711x/board-p720t.c
mach-imx/mach-mx21ads.c

2. The boards does not directly depend on the GPIO_GENERIC.
If GPIO_GENERIC is not selected then it still might create
a basic-mmio-gpio device. The device of course won't be in
such case supported by any driver.


Instead to solve the error the structure should be
always visible so:


-- >8 --
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Date: Tue, 12 Jan 2016 09:46:06 +0900
Subject: [PATCH] gpio: generic: Fix build error of missing bgpio_pdata
 declaration

Commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
introduced struct bgpio_pdata along with users but made the declaration
hidden by CONFIG_GPIO_GENERIC.

This results in the following build error:

arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: 	excess elements in struct initializer
arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:	(near initialization for '(anonymous)')
arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:	invalid use of undefined type 'struct bgpio_pdata'

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Reported-by: Guenter Roeck <linux@...ck-us.net>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
---
 include/linux/gpio/driver.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index e2d05fd0e6e3..7b9054366e7a 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -220,14 +220,13 @@ static inline void *gpiochip_get_data(struct gpio_chip *chip)
 
 struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
 
-#if IS_ENABLED(CONFIG_GPIO_GENERIC)
-
 struct bgpio_pdata {
 	const char *label;
 	int base;
 	int ngpio;
 };
 
+#if IS_ENABLED(CONFIG_GPIO_GENERIC)
 int bgpio_init(struct gpio_chip *gc, struct device *dev,
 	       unsigned long sz, void __iomem *dat, void __iomem *set,
 	       void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
-- 
1.9.1