linux-kernel - Re: [PATCH v4 1/2] PCI support added to ARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5694CD8F.1060706@synopsys.com>
Date:	Tue, 12 Jan 2016 09:55:27 +0000
From:	Joao Pinto <Joao.Pinto@...opsys.com>
To:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Joao Pinto <Joao.Pinto@...opsys.com>, <helgaas@...nel.org>
CC:	<Vineet.Gupta1@...opsys.com>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-snps-arc@...ts.infradead.org>,
	<CARLOS.PALMINHA@...opsys.com>, <Alexey.Brodkin@...opsys.com>,
	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>
Subject: Re: [PATCH v4 1/2] PCI support added to ARC

Hi Vineet,

On 1/12/2016 6:05 AM, Vineet Gupta wrote:
> On Monday 11 January 2016 10:54 PM, Joao Pinto wrote:
>> This patch adds PCI support to ARC and updates drivers/pci Makefile enabling
>> the ARC arch to use the generic PCI setup functions.
>>
>> Signed-off-by: Joao Pinto <jpinto@...opsys.com>
> 
> BTW this patch has whitespace errors still - can you make sure they are not in the
> next version(s)

By executing checkpatch.pl no whitespaces were detected:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
This patch adds PCI support to ARC and updates drivers/pci Makefile enabling

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#132:
new file mode 100644

total: 0 errors, 2 warnings, 212 lines checked

0001-PCI-support-added-to-ARC.patch has style problems, please review.

> 
> -Vineet
> 

I am going to check your comments and make the necessary adjustments.

Thanks,
Joao