linux-kernel - Re: [PATCH] mm: add ratio in slabinfo print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56945142.5040509@huawei.com>
Date:	Tue, 12 Jan 2016 09:05:06 +0800
From:	Xishi Qiu <qiuxishi@...wei.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Michal Hocko <mhocko@...nel.org>, <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>, <iamjoonsoo.kim@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	zhong jiang <zhongjiang@...wei.com>,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: add ratio in slabinfo print

On 2016/1/12 8:20, David Rientjes wrote:

> On Mon, 11 Jan 2016, Xishi Qiu wrote:
> 
>>> On Mon 11-01-16 11:54:57, Xishi Qiu wrote:
>>>> Add ratio(active_objs/num_objs) in /proc/slabinfo, it is used to show
>>>> the availability factor in each slab.
>>>
>>> What is the reason to add such a new value when it can be trivially
>>> calculated from the userspace?
>>>
>>> Besides that such a change would break existing parsers no?
>>
>> Oh, maybe it is.
>>
> 
> If you need the information internally, you could always create a library 
> around slabinfo and export the information for users who are interested 
> for your own use.  Doing anything other than appending fields to each line 
> is too dangerous, however, as a general rule.
> 
> 

OK, I know.

Thanks,
Xishi Qiu