linux-kernel - Re: [PATCH] rtc: max77xxx: fix of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5694E19A.2050107@nvidia.com>
Date:	Tue, 12 Jan 2016 16:50:58 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Julia Lawall <julia.lawall@...6.fr>
CC:	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linus.walleij@...aro.org>, <gnurou@...il.com>,
	<lee.jones@...aro.org>, <broonie@...nel.org>,
	<a.zummo@...ertech.it>, <alexandre.belloni@...e-electrons.com>,
	<lgirdwood@...il.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
	<rtc-linux@...glegroups.com>, <swarren@...dia.com>,
	<treding@...dia.com>, <k.kozlowski@...sung.com>
Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings

Hi Julia,
Thanks for pointing this issue.

What script do you run to get this error?

I tried to run script/coccicheck and it did not showed this issue.

When I run make with coccicheck per Documentation, it did not show 
specific to this error. Although, there was lots of output.

I want to get this type of error by running script.
Any command for this?

Thanks,
Laxman



On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
>   rtc-max77xxx.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- a/drivers/rtc/rtc-max77xxx.c
> +++ b/drivers/rtc/rtc-max77xxx.c
> @@ -480,6 +480,7 @@ static const struct platform_device_id m
>   	{ .name = "max77xxx-rtc", },
>   	{ .name = "max77620-rtc", },
>   	{ .name = "max20024-rtc", },
> +	{},
>   };
>
>   static struct platform_driver max77xxx_rtc_driver = {