linux-kernel - Re: mfd-dm355evm_msp: One function call less in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5694EF91.70609@users.sourceforge.net>
Date:	Tue, 12 Jan 2016 13:20:33 +0100
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after
 error detection

> The subject format is wrong

Which format do you expect?


> and the summary itself isn't very informative.

Which wording do you find more useful?


>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Tue, 29 Dec 2015 13:56:42 +0100
> 
> This patch format is wrong,

You might find the use of additional fields in the message body unusual.
I have got an other impression from the canonical patch format.


> please consider using `git format-patch` and `git send-email`.

Thanks for your suggestion.


>> The platform_device_put() function was called in one case by the
>> add_child() function during error handling even if the passed
>> variable "pdev" contained a null pointer.
>>
>> Implementation details could be improved by the adjustment of jump targets
>> according to the Linux coding style convention.

I am going to integrate the source code changes that you requested a bit later.


>> +report_failure:
>> +	dev_err(&client->dev, "can't add %s dev\n", name);
> 
> This isn't a very friendly error message.  Better to convert the
> dev_dbg() calls to dev_err() and tell the user what the problem was.

Which information display would be more appropriate here?

Regards,
Markus