linux-kernel - Re: [v2,2/2] cxl: use -Werror only with CONFIG_PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160112123245.7152514076E@ozlabs.org>
Date:	Tue, 12 Jan 2016 23:32:45 +1100 (AEDT)
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Brian Norris <computersforpeace@...il.com>,
	Ian Munsie <imunsie@....ibm.com>,
	Michael Neuling <mikey@...ling.org>
Cc:	Arnd Bergmann <arnd@...db.de>, Anton Blanchard <anton@....ibm.com>,
	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.com>,
	Joe Perches <joe@...ches.com>,
	Brian Norris <computersforpeace@...il.com>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [v2,2/2] cxl: use -Werror only with CONFIG_PPC_WERROR

On Fri, 2016-08-01 at 18:30:10 UTC, Brian Norris wrote:
> Some developers really like to have -Werror enabled for their code, as
> it helps to ensure warning free code. Others don't want -Werror, as it
> (for example) can cause problems when newer (or older) compilers have
> different sets of warnings, or new warnings can appear just when turning
> up the warning level (e.g., make W=1 or W=2). Thus, it seems prudent to
> have the use of -Werror be configurable.
> 
> It so happens that cxl is only built on PowerPC, and PowerPC already
> has a nice set of Kconfig options for this, under CONFIG_PPC_WERROR. So
> let's use that, and the world is a happy place again! (Note that
> PPC_WERROR defaults to =y, so the common case compile should still be
> enforcing -Werror.)
> 
> Fixes: d3d73f4b38a8 ("cxl: Compile with -Werror")
> Signed-off-by: Brian Norris <computersforpeace@...il.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/57f7c3932516b9f7908d9b0a24

cheers