linux-kernel - Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160112133915.GV6262@quack.suse.cz>
Date:	Tue, 12 Jan 2016 14:39:15 +0100
From:	Jan Kara <jack@...e.cz>
To:	Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:	'Jan Kara' <jack@...e.cz>, Jan Kara <jack@...e.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed
 intermediate storage

  Hi Andrew,

On Mon 11-01-16 16:31:40, Andrew Gabbasov wrote:
> > >  
> > > -	ocu[length - 1] = (uint8_t)u_len + 1;
> > > -	return u_len + 1;
> > > +	return u_len;
> >
> > It seems you removed setting of the length in the resulting CS0 string.
> 
> Yes, and it was done deliberately.
> udf_name_to_CS0 and its caller udf_put_filename functions are used for
> writing File Identifier fields only, which are not "dstrings", that is
> not containing the length in last byte. The last byte with the length
> from these functions would not be copied to filesystem or used in any
> other way.

I see, you are right. OK.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR