linux-kernel - Re: [PATCH 16/53 v2] perf tools: Fix mmap2 event allocation in synthesize code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112142426.GT18367@kernel.org>
Date:	Tue, 12 Jan 2016 11:24:26 -0300
From:	"acme@...nel.org" <acme@...nel.org>
To:	"Wangnan (F)" <wangnan0@...wei.com>
Cc:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	He Kuang <hekuang@...wei.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Zefan Li <lizefan@...wei.com>,
	"pi3orama@....com" <pi3orama@....com>
Subject: Re: [PATCH 16/53 v2] perf tools: Fix mmap2 event allocation in
 synthesize code

Em Tue, Jan 12, 2016 at 06:51:07PM +0800, Wangnan (F) escreveu:
> On 2016/1/12 18:49, 平松雅巳 / HIRAMATU，MASAMI wrote:
> >>From: Wang Nan [mailto:wangnan0@...wei.com]
> >>perf_event__synthesize_mmap_events() issues mmap2 events, but the
> >>memory of that event is allocated using:
> >>
> >>mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size);
> >>
> >>If path of mmap source file is long (near PATH_MAX), random crash
> >>would happen. Should use sizeof(mmap_event->mmap2).
> >>
> >>Fix two memory allocations.
> >Looks good to me. But hope to have another rename patch soon after this...
> 
> According to Arnaldo, we don't need rename patch. He think mmap_event
> is okay. Right?

Right, no need for the rename.

- Arnaldo