linux-kernel - Re: [PATCH v15 02/25] tools: Make list.h self-sufficient

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2016 11:54:06 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH v15 02/25] tools: Make list.h self-sufficient

Em Tue, Jan 12, 2016 at 01:35:40PM +0100, Borislav Petkov escreveu:
> On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> > Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
> 
> nitpick: we like to do this commit quoting style:
> 
>   7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")
> 
> Checkpatch catches that:
> 
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
> #21: 
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

I'm fixing this up and taking this patch, ok?

- Arnaldo
 
> > version of list.h, which broke the stacktool build because the tools
> > list.h includes the kernel list.h.
> > 
> > Avoid this type of situation in the future and make list.h
> > self-sufficient by copying the kernel list.h routines directly into
> > tools list.h.
> > 
> > This is a straight copy except for adjustments to the include statements
> > and copying of the tools-specific list routines (list_del_range and
> > list_for_each_from).
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > ---
> >  tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 747 insertions(+), 6 deletions(-)
> 
> ...
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.