linux-kernel - Re: [PATCH] [media] media: Kconfig: add dependency of HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112160555.GA6866@sudip-laptop>
Date:	Tue, 12 Jan 2016 21:35:56 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Sakari Ailus <sakari.ailus@....fi>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, hverkuil@...all.nl,
	pawel@...iak.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com
Subject: Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA

On Tue, Jan 12, 2016 at 04:10:43PM +0200, Sakari Ailus wrote:
> On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> > On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > > The build of m32r allmodconfig fails with the error:
> > > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > > 	error: implicit declaration of function 'dma_get_cache_alignment'
> > > 
> > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > > videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > > ---
> > 
> > A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> > log is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> 
> Hi Sudip,
> 
> Even though the issue now manifests itself on m32r, the problem is wider
> than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> set.
> 
> I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

I have checked with all the Kconfig which selects VIDEOBUF2_DMA_CONTIG
and all of them does depend on HAS_DMA. This is the only place where it
was missing.

regards
sudip