linux-kernel - Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112164641.GA9246@yury-N73SV>
Date:	Tue, 12 Jan 2016 19:46:41 +0300
From:	Yury Norov <ynorov@...iumnetworks.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<catalin.marinas@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <pinskia@...il.com>,
	<Prasun.Kapoor@...iumnetworks.com>, <schwab@...e.de>,
	<Nathan_Lynch@...tor.com>, <agraf@...e.de>,
	<klimov.linux@...il.com>, <broonie@...nel.org>,
	<jan.dakinevich@...il.com>, <ddaney.cavm@...il.com>,
	<bamvor.zhangjian@...wei.com>,
	<philipp.tomsich@...obroma-systems.com>, <joseph@...esourcery.com>,
	<christoph.muellner@...obroma-systems.com>
Subject: Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c

On Fri, Jan 08, 2016 at 10:08:44AM +0100, Arnd Bergmann wrote:
> On Friday 08 January 2016 02:34:29 Yury Norov wrote:
> > +
> > +#include "../../../fs/compat_binfmt_elf.c"
> > 
> 
> This is the wrong file, you have to include fs/binfmt_elf.c, otherwise
> you pick up the same definitions that you have for the other one.
> 

I chose compat as it's how it wokrs now. It redefines some types like
user_long_t, and I think it's neccessary for ILP32, as for aarch32.

> Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c
> and use fs/compat_binfmt_elf.c here if that makes the code nicer, you
> just can use the compat file for both or things get ugly because of
> the extra indirections.
> 
> 	Arnd