linux-kernel - Re: [PATCH v15 00/25] Compile-time stack metadata validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112175031.GE310@treble.redhat.com>
Date:	Tue, 12 Jan 2016 11:50:31 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	David Vrabel <david.vrabel@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Alok Kataria <akataria@...are.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Mathias Krause <minipli@...linux.so>,
	Pavel Machek <pavel@....cz>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>,
	Matt Fleming <matt@...eblueprint.co.uk>
Subject: Re: [PATCH v15 00/25] Compile-time stack metadata validation

On Tue, Jan 12, 2016 at 06:17:13PM +0100, Borislav Petkov wrote:
> On Fri, Dec 18, 2015 at 06:39:14AM -0600, Josh Poimboeuf wrote:
> > This is v15 of the compile-time stack metadata validation patch set,
> > along with proposed fixes for many of the warnings it found.  It's based
> > on the tip/master branch.
> 
> Ok,
> 
> Reviewed-by: Borislav Petkov <bp@...e.de>

Thanks a lot for your review!

> With it applied, my .config gives ~1000 stacktool warnings.

Hm, that's kind of shocking.  Any chance you have CONFIG_GCOV_KERNEL
enabled?  I just discovered that it inserts a bunch of unreachable
instructions which causes a lot of stacktool warnings.  I need to look
into that.

Otherwise, if you don't have gcov enabled, can you share your .config?

-- 
Josh