linux-kernel - Re: [PATCH v4 11/11] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56955941.1080701@hurleysoftware.com>
Date:	Tue, 12 Jan 2016 11:51:29 -0800
From:	Peter Hurley <peter@...leysoftware.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kevin Cernekee <cernekee@...il.com>,
	Jon Hunter <jonathanh@...dia.com>,
	Sebastian Frias <sf84@...oste.net>,
	Paul Burton <paul.burton@...tec.com>
Subject: Re: [PATCH v4 11/11] serial: 8250_omap: Add omap8250 earlycon

Wasn't planning on sending this patch just yet, but oh well.

On 01/12/2016 11:41 AM, Peter Hurley wrote:
> Add DT earlycon for 8250_omap driver. This boot console is included
> for kernels built with CONFIG_SERIAL_EARLYCON=y, CONFIG_OF=y,
> CONFIG_SERIAL_8250_OMAP=y, and CONFIG_OF_EARLY_FLATTREE=y.
> 
> This boot console is enabled with the command line option "earlycon"
> (without "=<name>...") when the DT 'stdout-path' property matches a
> compatible uart. For example,
> 
> / {
>    chosen {
>         stdout-path = "serial0:115200";
>    };
> 
>    ....
> 
>    aliases {
>         serial0 = &uart0;
>    };
> 
>    ....
> 
>    ocp : ocp {
>         uart0 : serial@...09000 {
>              compatible = "ti,omap3-uart";
>         }
>    };
> };
> 
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>
> ---
>  drivers/tty/serial/8250/8250_early.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index e7cdc0c..d1f6310 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -201,3 +201,23 @@ EARLYCON_DECLARE(rt288x, early_rt288x_setup);
>  OF_EARLYCON_DECLARE(rt288x, "ralink,rt2880-uart", early_rt288x_setup);
>  
>  #endif /* CONFIG_SERIAL_8250_RT288X */

This patch may not apply because the context is sitting on top of
unsubmitted code. Sorry.

Regards,
Peter Hurley

> +
> +#ifdef CONFIG_SERIAL_8250_OMAP
> +
> +static int __init early_omap8250_setup(struct earlycon_device *device,
> +				       const char *options)
> +{
> +	struct uart_port *port = &device->port;
> +
> +	if (!(device->port.membase || device->port.iobase))
> +		return -ENODEV;
> +
> +	port->regshift = 2;
> +	device->con->write = early_serial8250_write;
> +	return 0;
> +}
> +
> +OF_EARLYCON_DECLARE(omap8250, "ti,omap2-uart", early_omap8250_setup);
> +OF_EARLYCON_DECLARE(omap8250, "ti,omap3-uart", early_omap8250_setup);
> +OF_EARLYCON_DECLARE(omap8250, "ti,omap4-uart", early_omap8250_setup);
> +#endif
>