linux-kernel - Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160112124023.1ef170d5@jclayton-pc>
Date:	Tue, 12 Jan 2016 12:40:23 -0800
From:	Joshua Clayton <stillcompiling@...il.com>
To:	Lucas Stach <dev@...xeye.de>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04

Hi Lucas,
Thanks for the review. 

On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@...xeye.de> wrote:

> >  drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
> 
> Missing documentation for the DT binding.
>

Thanks, will add. 

...

> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
> 
> >  static const struct display_timing hannstar_hsd070pww1_timing = {
> >  	.pixelclock = { 64300000, 71100000, 82000000 },
> >  	.hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> >  		.compatible = "hannstar,hsd070pww1",
> >  		.data = &hannstar_hsd070pww1,
> >  	}, {
> > +		.compatible = "sharp,lq101k1ly04",
> > +		.data = &sharp_lq101k1ly04,
> > +	}, {
> 
> Wrong insertion place again.
OK. Will reorder alphabetically also. 

Joshua