lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jan 2016 16:19:50 +0900 From: Milo Kim <milo.kim@...com> To: <tglx@...utronix.de> CC: <boris.brezillon@...e-electrons.com>, Milo Kim <milo.kim@...com>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <marc.zyngier@....com>, Ludovic Desroches <ludovic.desroches@...el.com>, Nicholas Ferre <nicolas.ferre@...el.com>, <linux-kernel@...r.kernel.org>, "#v3 . 17+" <stable@...r.kernel.org> Subject: [PATCH 2/4] irqchip: atmel-aic: Fix wrong bit operation for IRQ priority Atmel AIC has common structure for SMR (Source Mode Register). bit[6:5] Interrupt source type bit[2:0] Priority level Other bits are unused. To update new priority value, bit[2:0] should be cleared first and then new priority level can be written. However, aic_common_set_priority() helper clears source type bits instead of priority bits. This patch fixes wrong mask bit operation. Fixes: b1479ebb7720 ("irqchip: atmel-aic: Add atmel AIC/AIC5 drivers") Signed-off-by: Milo Kim <milo.kim@...com> Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Jason Cooper <jason@...edaemon.net> Cc: Marc Zyngier <marc.zyngier@....com> Cc: Ludovic Desroches <ludovic.desroches@...el.com> Cc: Nicholas Ferre <nicolas.ferre@...el.com> Cc: linux-kernel@...r.kernel.org Cc: <stable@...r.kernel.org> #v3.17+ --- drivers/irqchip/irq-atmel-aic-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c index 2f2d73e..661840b 100644 --- a/drivers/irqchip/irq-atmel-aic-common.c +++ b/drivers/irqchip/irq-atmel-aic-common.c @@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val) priority > AT91_AIC_IRQ_MAX_PRIORITY) return -EINVAL; - *val &= AT91_AIC_PRIOR; + *val &= ~AT91_AIC_PRIOR; *val |= priority; return 0; -- 2.7.0
Powered by blists - more mailing lists