linux-kernel - Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2016 00:31:11 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Jeffrey Lin <yajohn@...il.com>
Cc:	Henrik Rydberg <rydberg@...omail.se>,
	Doug Anderson <dianders@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Scott Liu <scott.liu@....com.tw>,
	"jeffrey.lin" <jeffrey.lin@...-ic.com>, roger.yang@...-ic.com,
	KP.li@...-ic.com, lkml <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver

Jeffrey,

On Tue, Jan 12, 2016 at 11:49 PM, Jeffrey Lin <yajohn@...il.com> wrote:
> This patch is porting Raydium I2C touch driver. Developer can enable raydium touch driver by modifying define
> "CONFIG_TOUCHSCREEN_RM_TS".
>
> Signed-off-by: jeffrey.lin<jeffrey.lin@...-ic.com>
> ---
>  drivers/input/touchscreen/Kconfig      |  12 +
>  drivers/input/touchscreen/Makefile     |   1 +
>  drivers/input/touchscreen/rm31100_ts.c | 772 +++++++++++++++++++++++++++++++++
>  3 files changed, 785 insertions(+)
>  create mode 100644 drivers/input/touchscreen/rm31100_ts.c

Thank you for sending the full patch. Unfortunately it does not even compile:

dtor@...r-ws:~/kernel/work$ make drivers/input/touchscreen/rm31100_ts.o
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/input/touchscreen/rm31100_ts.o
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm_fw_version_show’:
drivers/input/touchscreen/rm31100_ts.c:190:7: error: request for
member ‘u8_version’ in something not a structure or union
   info.u8_version,
       ^
drivers/input/touchscreen/rm31100_ts.c:191:7: error: request for
member ‘u8_sub_version’ in something not a structure or union
   info.u8_sub_version);
       ^
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm_ts_power_on’:
drivers/input/touchscreen/rm31100_ts.c:304:2: error: implicit
declaration of function ‘regulator_enable’
[-Werror=implicit-function-declaration]
  error = regulator_enable(ts->avdd);
  ^
drivers/input/touchscreen/rm31100_ts.c:317:3: error: implicit
declaration of function ‘regulator_disable’
[-Werror=implicit-function-declaration]
   regulator_disable(ts->dvdd);
   ^
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm31100_ts_suspend’:
drivers/input/touchscreen/rm31100_ts.c:392:6: warning: unused variable
‘rc’ [-Wunused-variable]
  int rc = 0;
      ^
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm31100_ts_probe’:
drivers/input/touchscreen/rm31100_ts.c:581:2: error: implicit
declaration of function ‘devm_regulator_get’
[-Werror=implicit-function-declaration]
  ts->avdd = devm_regulator_get(&client->dev, "avdd");
  ^
drivers/input/touchscreen/rm31100_ts.c:581:11: warning: assignment
makes pointer from integer without a cast [enabled by default]
  ts->avdd = devm_regulator_get(&client->dev, "avdd");
           ^
drivers/input/touchscreen/rm31100_ts.c:591:11: warning: assignment
makes pointer from integer without a cast [enabled by default]
  ts->dvdd = devm_regulator_get(&client->dev, "dvdd");
           ^
drivers/input/touchscreen/rm31100_ts.c:601:2: error: too few arguments
to function ‘devm_gpiod_get’
  ts->resout_gpio = devm_gpiod_get(&client->dev, "rm31100_resout_gpio");
  ^
In file included from drivers/input/touchscreen/rm31100_ts.c:31:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^
drivers/input/touchscreen/rm31100_ts.c:664:61: error: ‘err’ undeclared
(first use in this function)
   dev_err(&client->dev, "%s crated failed, %d\n", __func__, err);
                                                             ^
drivers/input/touchscreen/rm31100_ts.c:664:61: note: each undeclared
identifier is reported only once for each function it appears in
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm31100_ts_init’:
drivers/input/touchscreen/rm31100_ts.c:754:4: error:
‘driver_attr_myAttr’ undeclared (first use in this function)
   &driver_attr_myAttr);
    ^
drivers/input/touchscreen/rm31100_ts.c: At top level:
drivers/input/touchscreen/rm31100_ts.c:172:12: warning:
‘rm31100_ts_write’ defined but not used [-Wunused-function]
 static int rm31100_ts_write(struct i2c_client *client, u8 *buf, int num)
            ^
drivers/input/touchscreen/rm31100_ts.c: In function ‘rm_fw_version_show’:
drivers/input/touchscreen/rm31100_ts.c:192:1: warning: control reaches
end of non-void function [-Wreturn-type]
 }
 ^
cc1: some warnings being treated as errors
make[1]: *** [drivers/input/touchscreen/rm31100_ts.o] Error 1
make: *** [drivers/input/touchscreen/rm31100_ts.o] Error 2
dtor@...r-ws:~/kernel/work$

Please next time submit version that you actually tested.

Thank you.

-- 
Dmitry