linux-kernel - Re: [PATCH -next] gpio: mpc8xxx: Do not use gpiochip_get_data() in mpc8xxx_gpio_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb0H5VGku2Lm_FsyGMVSZ5KjyMGS9ywmQ-BYgnv531JEw@mail.gmail.com>
Date:	Wed, 13 Jan 2016 10:22:46 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Alexander Stein <alexander.stein@...tec-electronic.com>
Subject: Re: [PATCH -next] gpio: mpc8xxx: Do not use gpiochip_get_data() in mpc8xxx_gpio_save_regs()

On Thu, Jan 7, 2016 at 5:25 PM, Guenter Roeck <linux@...ck-us.net> wrote:

> Commit 709d71a17c33 ("gpio: mpc8xxx: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). However, the data
> pointer is not yet set by the time the save_regs function is called.
>
> Fixes: 709d71a17c33 ("gpio: mpc8xxx: use gpiochip data pointer")
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Alexander Stein <alexander.stein@...tec-electronic.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Patch applied.

Yours,
Linus Walleij