linux-kernel - Re: [RFC 6/6] perf build: Introduce FEATURES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160113100328.GA5515@krava.brq.redhat.com>
Date:	Wed, 13 Jan 2016 11:03:28 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Wangnan (F)" <wangnan0@...wei.com>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable

On Wed, Jan 13, 2016 at 05:46:13PM +0800, Wangnan (F) wrote:

SNIP

> >
> >I'll try to check on that.. does this patch help to improve
> >the current speed or do you need to solve this to get substantial
> >speedup?
> 
> I'm working on it. I have already done it, but still have some
> problem. On some machine 'make_static' test target lost
> '-liberty -lz' in its linker options. Seems something wrong in
> this part:
> 
> ifeq ($(feature-libbfd), 1)
>   EXTLIBS += -lbfd
> 
>   # call all detections now so we get correct
>   # status in VF output
>   $(call feature_check,liberty)
>   $(call feature_check,liberty-z)
>   $(call feature_check,cplus-demangle)
> 
>   ifeq ($(feature-liberty), 1)
>     EXTLIBS += -liberty
>   else
>     ifeq ($(feature-liberty-z), 1)
>       EXTLIBS += -liberty -lz
>     endif
>   endif
> endif

IIRC we had issues with this before.. different systems
provide those libs in different way, like:
  2cf9040714f3 perf tools: Fix bfd dependency libraries detection

you might want to check feature detection code if it gets
built properly on your system

jirka