linux-kernel - Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2016 13:33:57 +0100 (CET)
From:	Karol Herbst <desurium@...olherbst.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	David Airlie <airlied@...ux.ie>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [patch] drm/nouveau/pci: reversed condition in
 nvkm_pcie_set_link()

> Karol Herbst <nouveau@...olherbst.de> hat am 13. Januar 2016 um 13:30
> geschrieben:
> 
> Hi Dan,
> 
> yeah I also catched that. I assume something went wrong in the review process,
> because I am sure I didn't added that "pci ||" check myself ;) but who knows,
> maybe I was tired working with ben on that, cause it was like 4am while doing

maybe I chose the wrong words here. Seems like I still need to improve my
english here and there ;)

I meant that I was literally tired, cause it was 4am, not that I was tired
because of ben. Just clarify that before somebody thinks I am a mean person.

> the last polishing steps.
> 
> nvm, I already send a patch to the nouveau ML:
> http://lists.freedesktop.org/archives/nouveau/2016-January/023772.html
> 
> I just tried to poke ben the last day like several times, but he didn't seem
> to
> be there yesterday
> 
> > Dan Carpenter <dan.carpenter@...cle.com> hat am 13. Januar 2016 um 13:21
> > geschrieben:
> > 
> > The condition is reversed so this function is a no-op.
> > 
> > Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed
> > change')
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > index b32954f..d71e5db 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum
> > nvkm_pcie_speed speed, u8 width)
> > struct pci_bus *pbus;
> > int ret;
> > 
> > - if (pci || !pci_is_pcie(pci->pdev))
> > + if (!pci || !pci_is_pcie(pci->pdev))
> > return 0;
> > pbus = pci->pdev->bus;
> 
> >