linux-kernel - Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160113125514.GE1540@katana>
Date:	Wed, 13 Jan 2016 13:55:14 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linux I2C <linux-i2c@...r.kernel.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	Magnus Damm <magnus.damm@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Jan Luebbe <jlu@...gutronix.de>
Subject: Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver


> > +struct i2c_demux_pinctrl_priv {
> > +       int cur_chan;
> > +       int num_chan;
> 
> This is always positive, so you can make num_chan and a few loop counters
> unsigned.

Nope, sadly not. cur_chan can get a -ERRNO, and the type of num_chan is
defined by the return type of of_count_phandle_with_args().


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)